Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 66318 invoked from network); 27 Dec 2006 03:00:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Dec 2006 03:00:02 -0000 Received: (qmail 56562 invoked by uid 500); 27 Dec 2006 03:00:02 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 56516 invoked by uid 500); 27 Dec 2006 03:00:02 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 56505 invoked by uid 500); 27 Dec 2006 03:00:01 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 56501 invoked by uid 99); 27 Dec 2006 03:00:01 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Dec 2006 19:00:01 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Dec 2006 18:59:54 -0800 Received: by brutus.apache.org (Postfix, from userid 33) id 3A3BB7142BB; Tue, 26 Dec 2006 18:59:34 -0800 (PST) From: bugzilla@apache.org To: tomcat-dev@jakarta.apache.org Subject: DO NOT REPLY [Bug 40177] - RequestDumperValve causes getCharacterEncoding to be called In-Reply-To: X-Bugzilla-Reason: AssignedTo Message-Id: <20061227025934.3A3BB7142BB@brutus.apache.org> Date: Tue, 26 Dec 2006 18:59:34 -0800 (PST) X-Virus-Checked: Checked by ClamAV on apache.org DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=40177 jason_brittain@yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Additional Comments From jason_brittain@yahoo.com 2006-12-26 18:59 ------- Hi Yoav. Making the Javadocs more informative is indeed helpful. But, both Valves and Filters exist separately because they are useful for different use cases: Valves are useful when the administrator wants to do something with requests at the servlet container level, without modifying webapps that may or may not be owned or written by the administrator. Filters are useful when you are the webapp author, or when you're able and willing to modify the webapp, to do something with requests. There are valid uses for each, and the administrator should choose for themselves from the available options. I have found RequestDumperValve useful on a number of occasions where I wanted more info about the requests/responses to web applications I've developed, plus webapps that I didn't write. That includes webapps that were localized and internationalized (in development, not every bug needs to be investigated in character sets other than ISO8859-1). The RequestDumperValve has been around for quite a while now, and I find it quite useful, even if it doesn't do everything. Reopening to request the undeprecation of RequestDumperValve. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org