tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r482093 - /tomcat/connectors/trunk/jk/native/common/jk_status.c
Date Wed, 06 Dec 2006 11:47:26 GMT
I think it's perfectly valid having to simply use "&" in URLs, no need 
to encode. On the other hand as long as we don't have a proper decoding 
for the incoming URLs and I don't know, if all supported web servers 
decode before putting the query string into our service struct, I would 
prefer to stick with the original notation (not encoded).

mturk@apache.org wrote:
> Author: mturk
> Date: Sun Dec  3 23:11:47 2006
> New Revision: 482093
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=482093
> Log:
> Use &amp; instead & directly.
> 
> Modified:
>     tomcat/connectors/trunk/jk/native/common/jk_status.c
> 
> Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=482093&r1=482092&r2=482093
> ==============================================================================
> --- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
> +++ tomcat/connectors/trunk/jk/native/common/jk_status.c Sun Dec  3 23:11:47 2006
> @@ -900,21 +900,21 @@
>          jk_putv(s, s->req_uri, "?", JK_STATUS_ARG_CMD, "=",
>                  status_cmd_text(cmd), NULL);
>          if (mime)
> -            jk_putv(s, "&", JK_STATUS_ARG_MIME, "=",
> +            jk_putv(s, "&amp;", JK_STATUS_ARG_MIME, "=",
>                      status_mime_text(mime), NULL);
>          if (from)
> -            jk_putv(s, "&", JK_STATUS_ARG_FROM, "=",
> +            jk_putv(s, "&amp;", JK_STATUS_ARG_FROM, "=",
>                      status_cmd_text(from), NULL);
>          if (refresh)
> -            jk_printf(s, "&%s=%d", JK_STATUS_ARG_REFRESH, refresh);
> +            jk_printf(s, "&amp;%s=%d", JK_STATUS_ARG_REFRESH, refresh);
>          if (worker)
> -            jk_putv(s, "&", JK_STATUS_ARG_WORKER, "=",
> +            jk_putv(s, "&amp;", JK_STATUS_ARG_WORKER, "=",
>                      worker, NULL);
>          if (sub_worker)
> -            jk_putv(s, "&", JK_STATUS_ARG_WORKER_MEMBER, "=",
> +            jk_putv(s, "&amp;", JK_STATUS_ARG_WORKER_MEMBER, "=",
>                      sub_worker, NULL);
>          if (option)
> -            jk_putv(s, "&", JK_STATUS_ARG_OPTION, "=",
> +            jk_putv(s, "&amp;", JK_STATUS_ARG_OPTION, "=",
>                      option, NULL);
>      }
>      if (text)
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message