tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40177] - RequestDumperValve causes getCharacterEncoding to be called
Date Wed, 27 Dec 2006 02:59:34 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40177>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40177


jason_brittain@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Additional Comments From jason_brittain@yahoo.com  2006-12-26 18:59 -------
Hi Yoav.

Making the Javadocs more informative is indeed helpful.  But, both Valves
and Filters exist separately because they are useful for different use cases:
Valves are useful when the administrator wants to do something with requests
at the servlet container level, without modifying webapps that may or may not
be owned or written by the administrator.  Filters are useful when you are the
webapp author, or when you're able and willing to modify the webapp, to do
something with requests.  There are valid uses for each, and the administrator
should choose for themselves from the available options.  I have found
RequestDumperValve useful on a number of occasions where I wanted more info
about the requests/responses to web applications I've developed, plus
webapps that I didn't write.  That includes webapps that were localized and
internationalized (in development, not every bug needs to be investigated
in character sets other than ISO8859-1).  The RequestDumperValve has been
around for quite a while now, and I find it quite useful, even if it doesn't
do everything.

Reopening to request the undeprecation of RequestDumperValve.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message