tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r476817 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Date Sun, 19 Nov 2006 15:26:27 GMT
rjung@apache.org wrote:
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=476817
> -        if (ae->worker->socket_timeout > 0) {
> -            if (!jk_is_socket_connected(ae->sd)) {
> +        if (!jk_is_socket_connected(ae->sd)) {

+1. That's possible because socket connect detection
is not dependent on the socket timeout any more.



>              ((rc = ajp_connection_tcp_send_message(ae, op->request, l)) != JK_TRUE))
{
>              if (rc != JK_FATAL_ERROR) {
> -                jk_log(l, JK_LOG_INFO,
> +                jk_log(l, JK_LOG_DEBUG,
>                         "(%s) error sending request. Will try another pooled connection",

-1. Please change back to INFO because this is *not* part of
the normal operation.
If someone hates those messages he can increase the log level to warn.


> @@ -1219,8 +1219,8 @@
>              jk_log(l, JK_LOG_INFO,
>                     "(%s) all endpoints are disconnected or dead",
>                     ae->worker->name);
> -            JK_TRACE_EXIT(l);
> -            return JK_FALSE;
> +            jk_log(l, JK_LOG_INFO,
> +                   "Increase the backend idle connection timeout or the connection_pool_minsize");

I'm not sure about that either.
This is where retries should go into the action and be used for sticky sessions.
If the sticky sessions are false, there might be other workers in the lb that
are not disconnected.
OTOH if the retries is larger then 1 (2 is default) the same worker will be
used and the new connection will be made.

Regards,
Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message