tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r477001 - in /tomcat/container/tc5.5.x/webapps: admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java docs/changelog.xml
Date Mon, 20 Nov 2006 01:00:46 GMT
Author: markt
Date: Sun Nov 19 17:00:46 2006
New Revision: 477001

URL: http://svn.apache.org/viewvc?view=rev&rev=477001
Log:
Fix bug 40714. Username is not required in all circumstances for a DataSource.

Modified:
    tomcat/container/tc5.5.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java
    tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java
URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java?view=diff&rev=477001&r1=477000&r2=477001
==============================================================================
--- tomcat/container/tc5.5.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java
(original)
+++ tomcat/container/tc5.5.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/DataSourceForm.java
Sun Nov 19 17:00:46 2006
@@ -318,19 +318,6 @@
                            new ActionError("resources.error.driverClass.required"));
             }
             
-            // username is a required field
-            if ((username == null) || (username.length() < 1)) {
-                errors.add("username",
-                           new ActionError("users.error.username.required"));
-            }
-            
-            // commented out password can be an empty string
-            // password is a required field
-            //if ((password == null) || (password.length() < 1)) {
-            //    errors.add("password",
-            //               new ActionError("error.userPassword.required"));
-            //
-            
             // FIX ME -- need to do a range check
             numberCheck("active", active , false, 0, 10000);
             numberCheck("idle", idle , false, 0, 10000);

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=477001&r1=477000&r2=477001
==============================================================================
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Sun Nov 19 17:00:46 2006
@@ -172,6 +172,10 @@
         documentation. (markt)
       </fix>
       <fix>
+        <bug>40714</bug>: Admin webapp no longer requires a username for a
+        DataSource since it is not required in all cases. (markt)
+      </fix>
+      <fix>
         <bug>40720</bug>: Fix exception in admin webapp when adding a group to
         a user. (markt)
       </fix>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message