tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: svn commit: r451831 - in /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core: ApplicationDispatcher.java ApplicationFilterChain.java LocalStrings.properties
Date Sun, 01 Oct 2006 23:31:23 GMT

"Mark Thomas" <markt@apache.org> wrote in message 
news:452046AD.5070207@apache.org...
> Remy Maucherat wrote:
>> markt@apache.org wrote:
>>> Author: markt
>>> Date: Sun Oct  1 15:43:11 2006
>>> New Revision: 451831
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=451831
>>> Log:
>>> Fix bug 34956. Ensure requestDispatchers are called with original or
>>> wrapped original request/response objects as per SRV.8.2 and 
>>> SRV.14.2.5.1
>>
>> I think this "fix" is very evil enabled by default.
>
> I tend to agree on the grounds it is pretty pointless (BTW if you can
> see a better way of implementing it I'd be happy to come up with an
> alternative patch).
>

I'd have probably been less strict, and just thrown an ISE from 
ApplicationDispatcher.wrapRequest/wrapResponse.  Mine allows somebody that 
really wants to program against Tomcat sidestep the check, but doesn't add 
as much overhead.

> I don't see why the spec requires this but it does. How about porting
> the Globals.STRICT_SERVLET_COMPLIANCE feature from the 6.x branch?
>
> Mark 




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message