tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Funk <funk...@joedog.org>
Subject Re: svn commit: r467989 - in /tomcat/tc6.0.x/trunk/java: javax/servlet/ServletException.java org/apache/catalina/core/StandardWrapper.java org/apache/catalina/valves/ErrorReportValve.java
Date Thu, 26 Oct 2006 13:34:14 GMT
Its specifically to address bad user code. For example:

http://issues.apache.org/bugzilla/show_bug.cgi?id=39088

Its the case where ServletException.getCause() returns something an 
instance of "user's custom Throwable" .. then the "user's custom 
Throwable" returns itself as the root cause.

-Tim

Remy Maucherat wrote:
> Tim Funk wrote:
>> Adding this to both loops may be helpful too:
>> if (rootCause == rootCause.getCause()) {
>>     break;
>> }
> 
> Throwable.getCause does return null in that case, so the loop should get 
> out:
>     public Throwable getCause() {
>         return (cause==this ? null : cause);
>     }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message