tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/
Date Wed, 18 Oct 2006 18:20:09 GMT

Filip Hanik - Dev Lists wrote:
> Filip Hanik - Dev Lists wrote:
>>
>>
>> Mladen Turk wrote:
>>> fhanik@apache.org wrote:
>>>>  
>>>> -        ssl = endpoint.getSecure();
>>>> +        ssl = "on".equalsIgnoreCase(endpoint.getSSLEngine());
>>>>
>>>
>>> Like Remy said, anything except "Off" is acceptable.
>>> It can be either "On" or "EngineName" (eg, SSLEngine="nuron")
>> that's for APR, because of
>>        if (!"off".equalsIgnoreCase(SSLEngine)) {
>>            // Initialize SSL
>>            // FIXME: one per VM call ?
>>            if ("on".equalsIgnoreCase(SSLEngine)) {
>>                SSL.initialize(null);
>>            } else {
>>                SSL.initialize(SSLEngine);
>>            }
>>
>> In the HTTP connector, there is no other engine to initialize, hence 
>> the only values are on/off \
> btw, if the value for SSLEngine can only be used/initialized once per 
> VM, why not put the actual engine value in the APR listener, and not 
> in the connector
to eager to press send, that way the connector would have only on/off 
values, while the actual SSLEngine value neuron would be in the 
APRLifeCycleListener,
much cleaner, and all our connectors become consistent on that value

>
> Filip
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message