tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott Johnson <scott...@us.ibm.com>
Subject Tomcat 6: Incorrect ELContext may be used when PageContext pooling is 'on'
Date Fri, 01 Sep 2006 22:03:20 GMT
(I tried many times to open a bugzilla bug against Tomcat 6/Jasper, but it 
never succeeded.  I think this bug is important enough to let you know 
about it, while bugzilla-admin helps figure out my bugzilla problem.)


In org.apache.jasper.runtime.PageContextImpl, the release() method does 
not set the class variable elContext to null.  This can result in the 
ELContext from any JspApplicationContext to be used, resulting in 
incorrect EL evaluation.
For example, if the current JSP page requires a custom EL resolver that 
was registered in its application, and if the PageContext is gotten from 
the pool in JspFactoryImpl, then the elContext will not be null (so won't 
be created) and could therefore be from any other JspApplicationContext.

Fix:  in PageContextImpl.release()
        elContext = null;  // very important
        applicationContext = null;  // less important

I built the latest code from tc6.0.x/trunk and this problem exists as of 
this writing - and I didn't see it reported in bugzilla.

-Scott
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message