tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Costin Manolache" <cos...@apache.org>
Subject Re: Excessive Lock/Unlock Traffic
Date Fri, 21 Jul 2006 15:33:21 GMT
I'm pretty sure Mladen didn't intentionally do a 'svn lock/unlock' on each
file. Maybe his IDE did - he can
comment on what commands he used to perform the operation.

However, I don't see any reason for svn to send a mail whenever a file is
locked or unlocked - the
purpose ( AFAIK ) is to allow review and inform people of repository
activity - locking a file
doesn't look like something you would "-1", it's more of an internal svn/dav
thing.

Changing a property on all files in a repository is a normal, legal
operation that other
projects may do ( tomcat will probably avoid this in future :-).

If you think svn is correct in sending lock/unlock/proppatch mails for each
individual file ( without at least agreggating them ) - then
it would be good to inform projects on what to expect, how to turn off mail
before doing such changes, or
how to do this kind of changes without locking.

Costin


On 7/21/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
>
> On 7/21/06, Costin Manolache <costin@gmail.com> wrote:
> > Good to hear from infrastructure@ !
> >
> > We all agree that the svn lock/svn unlock traffic was a bad thing, and
> > even worse that 2 mails were sent for each file in the repository.
> > AFAIK this is result of changing a simple property in the tomcat
> repository
> > ( for
> > line ending ), and it's a serious bug in svn or how svn is configured to
> > generate all this spam. I think the change made in tomcat is perfectly
> > reasonable, and other projects may do similar things - I hope svn
> > will be fixed, or maybe infrastructure can add some filters to drop
> > such messages.
>
> It's not a bug in how svn is configured, it's a "bug" in the user
> understanding of the need for use of 'svn lock'.  You do not need to
> use svn lock just because you want to change the line endings.  Anyone
> who tells you otherwise is just plain wrong, and I'm saying that both
> with my ASF infra hat on and my Subversion developer hat on.  People
> change eol styles in repositories all over the world constantly
> without ever using 'svn lock' and 'svn unlock'.
>
> The only real justification for use of 'svn lock' is when you're
> making modifications to a file that intrinsically cannot be merged,
> and thus you want to prevent someone else from modifying it at the
> same time.  This might include images, .doc files, etc.  In that case
> the notification is critical because you don't want people to find out
> that the file has been locked when they go to do their commit.  In
> virtually all other cases (and especially in the ASF repository with
> its goal of collaborative development) there is no reason to ever use
> 'svn lock' at all.
>
> -garrett
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message