tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: NIO Connector, please review
Date Thu, 22 Jun 2006 16:16:55 GMT
Filip Hanik - Dev Lists wrote:
> Remy Maucherat wrote:
>> Filip Hanik - Dev Lists wrote:
>>> I did, just check
>>> http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2
>>> In terms of negativity, not sure where your head is at, but there is 
>>> none here.
>>
>> This was quite a subtle mention. The plan is that the socket will not 
>> get destroyed and deallocated before the error method of the servlet 
>> is called. If this is indeed done properly, then it is the 
>> application's fault and the Java code should not change. At the same 
>> time, I would like to get more robustness and add code for that in 
>> the native code, because in a very similar way, it is currently 
>> possible to crash Tomcat with APR using Java2D, which writes stuff 
>> asynchronously when finalizing its objects.
> yes, and I offered to help track these down and will do so.
>>
>>>> I quickly tested your NIO connector, and on Windows, it closes the 
>>>> connection after getting the first byte. I didn't have time to test 
>>>> further.
>>> Really, I ran through a large set of tests here and they all worked 
>>> fine, both chunked encoding and content length based data.
>>
>> I am not able to get any requests served at all right now (as I said, 
>> using a telnet, the connection gets closed without an error being 
>> logged after getting the first byte), while the other connectors work 
>> fine. The configuration is:
>>
>>     <Connector port="8080" />
>>
>>     <Connector port="8081" 
>> protocol="org.apache.coyote.http11.Http11NioProtocol" />
>>
>>     <Connector port="8082" 
>> protocol="org.apache.coyote.http11.Http11Protocol" />
> ok, lemme get on that one
Alright, fixed, my last night checkin, the one I was unable to diff, 
caused the problem, I have reverted that one, and the Connector since we 
can use the fully qualified classname here.

Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message