tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r416187 [1/3] - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/http11/ tomcat/util/net/
Date Thu, 22 Jun 2006 14:37:30 GMT
I agree, would you mind if I redid the connector, so that the 
protocolHandlerClassName works?
currently, it only checks the protocol, as it does so in the constructor 
of the Connector. so setting protocol or attributes later will have no 
effect

public void begin(Attributes attributes) throws Exception {
     digester.push(new Connector(attributes.getValue("protocol")));
}

Filip




Remy Maucherat wrote:
> fhanik@apache.org wrote:
>> -            if ("HTTP/1.1".equals(protocol)) {
>> +            if ("HTTP/1.1/NIO".equals(protocol)) {
>> +                
>> setProtocolHandlerClassName("org.apache.coyote.http11.Http11NioProtocol"); 
>>
>> +            } else if ("HTTP/1.1".equals(protocol)) {
>
> I think using the actual class name is far better than using arbitrary 
> protocol names.
>
> Rémy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


-- 


Filip Hanik

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message