tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Costin Manolache" <cos...@gmail.com>
Subject Re: svn commit: r409041 - in /tomcat/sandbox/java/org/apache/tomcat/util/net: ./ javaio/ nio/ res/ simple/
Date Wed, 24 May 2006 14:52:25 GMT
On 5/24/06, Remy Maucherat <remm@apache.org> wrote:
>
> costin@apache.org wrote:
> > Author: costin
> > Date: Tue May 23 19:50:33 2006
> > New Revision: 409041
> >
> > URL: http://svn.apache.org/viewvc?rev=409041&view=rev
> > Log:
> > Remove dead code - refactoring of the connector.
> >
> > Since having a common base is not likely - I'm using same approach as
> apr, i.e. separate connector,
> > duplicate some code ( but this may allow better cleanup )
>
> Is there anything wrong with the stuff I did in the main branch ? I
> would like to remove things like PoolTcpEndpoint, its friend the thread
> pool, ThreadPoolRunnable (thread locals work well; also, since it's the
> protocol handler that is selecting the processor, it allows tricks like
> what I did to support comet), and move to executors.


+1, the cleanup in the main branch is ok.

 I'm using the same aproach with the nio connector in sandbox - separate
connector,
no deps on old stuff.

Costin
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message