tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39296] New: - Misuse of Commons Logging
Date Thu, 13 Apr 2006 09:49:24 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39296>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39296

           Summary: Misuse of Commons Logging
           Product: Tomcat 5
           Version: Unknown
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: major
          Priority: P2
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: skitching@apache.org


The StandardContext class is responsible for webapp deployment. It creates an
org.apache.commons.logging.Log object on-demand. However the object might be
created when the TCCL is set to that of a webapp being deployed. This is really
bad, as the returned Log object is configured using the TCCL (and quite likely
points to an object whose Class is loaded from that webapp's lib dir). When the
log object is accessed later (for purposes unrelated to that webapp) things get
ugly.

One effect is that a logging configuration failure in one webapp can cause
catalina to fail to start, because using the log object causes an exception in
areas that are not caught and handled.

Specific class causing problem: StandardContext
Relevant method: listenerStart, listenerStop.

The fix is to ensure the Log object is created while the TCCL is NOT set to the
webapp (ie before StandardContext.listenerStart method sets the TCCL).

Tomcat version affected: 5.5.15

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message