tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39218] New: - Wrong order in TC class loading
Date Wed, 05 Apr 2006 21:19:02 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39218>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39218

           Summary: Wrong order in TC class loading
           Product: Tomcat 5
           Version: 5.5.16
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: rainer.jung@kippdata.de


I propose an enhancement for Bootstrap / ClassLoaderFactory.
At the moment, TC 5.5 gives the users the choice to define their class loader
configurations in catalina.properties. Each class loader is being configured via
a comma seperated list of places to look for classes.

Now Bootstrap and ClassLoaderFactory do something, a normal user does not
expect: they do not keep the order of the entries. They rearrange all entries,
such that all directories are searched first, then all *.jar type entries and at
the end all URL form entries. This leads to unexpected code being loaded (e.g.
in the case of adding product patches and adding instance specific classes etc.).

I attach a patch, which does only slightly change the code, but includes the
following changes:

1) Keep the order of entries when constructing the class loader
2) allow ${catalina.home} and ${catalina.base} not only at the beginning of
tokens (useful in the case of URLs)

The same patch applies to the yet unchanged classes in 6.0. If there is some
interest, I can contribute a patch for 5.0 as well.

I hope someone has a little spare time left to review the patch.

In case the patch is being applied, I would also send some documentation for
catalina.properties.

One last word: TC 5.5 hs a comment

# Please note that for individual jar files, e.g. bar.jar, you need the URL form
# starting with file:.

before shared.loader in catalina.proprties. This comment is no longer true in
5.5, even without this patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message