tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r395980 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/ManagerBase.java webapps/docs/changelog.xml
Date Sun, 23 Apr 2006 00:37:32 GMT
Remy Maucherat wrote:
> Filip Hanik - Dev Lists wrote:
>> Remy Maucherat wrote:
>>> Filip Hanik - Dev Lists wrote:
>>>> Peter Rossbach wrote:
>>>>> I plan to start refactoring that DeltaManager/DeltaSession at 
>>>>> current cluster and new ha cluster are real subclasses :-)
>>>>
>>>> that would be a -1, as we are not refactoring the current impl, 
>>>> that was the reason for the new modules to begin with. You were the 
>>>> one who suggested it :)
>>>> in the HA module, this is work in progress
>>>
>>> This change is something you promised to do aeons ago, and would 
>>> have avoided many bugs, so I think you should withdraw this -1.
>> that correct, and it is being implemented. But you were the one who 
>> dove in and stopped the refactoring two months ago, and also opted to 
>> create a new module in there, and that is where it is being done 
>> right now. Otherwise, the new module should have never happened, and 
>> we didn't have to keep two impls in sync.
>
> These statements are completely detached from reality.
>
> - I am not ok with someone (especially one reappearing from a year 
> long coma) who decides, for whatever reason, to rewrite everything in 
> the stable branch
yes, I forgot that you're the boss and obviously these are your 
decisions. I think your view of ASF and the actual reality seem to be a 
little detached. Maybe you can do this in *your* branch, I believe you 
said you had one of those going.


> - I am obviously ok with certain refactorings to be made, especially 
> when they have been done earlier
>
> Rémy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message