tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39296] - Misuse of Commons Logging
Date Thu, 27 Apr 2006 18:33:34 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39296>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39296





------- Additional Comments From darryl@darrylmiles.org  2006-04-27 18:33 -------
I agree with Simon.  This problem sounds like the my conclusion in Bug #37498
and the 2 line fix there.  Also similar comments at
http://marc.theaimsgroup.com/?t=114432545800007&r=1&w=4

Is the current "design" mandated by any specification or just a TC
implementation detail ?

Logging is somewhat of a religious issue in all Java development and each
container should allow as much freedom to the web-app developer as they can give
in this area.

This means to me that TC should take measures to protected itself from
undesirable logger runtime behaviour.  I dont think the logging calls (we are
talking about) within the container code are performance critical and believe a
balance can be achieved by wrapping all container code invokations on web-app
logger instances with code to eat exceptions (and possibily fallback to picking
up a container based logger instance on failure, global log).

The hi-jacking of the web-app logger instance for use by the container upon
matters relating to the context is nice, but should never destabalise the
container, the feature is not worth that.


> What is happening now is that the Log object can be initialised while the
> TCCL=webapp, then used later when code unrelated to that webapp is running.
> *That* is very bad.

Simon can you at least point out that code path ?

I have no new evidence to agree with this point right now since taking vacation
these past weeks and not having time to have retested latest TC.  But Remy
committed a patch in relation to Bug #38795 which might close the door on some
code paths you maybe finding.

So can you confirm you are using the latest TC which includes that change.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message