tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From billbar...@apache.org
Subject svn commit: r387091 - /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Request.java
Date Mon, 20 Mar 2006 00:51:47 GMT
Author: billbarker
Date: Sun Mar 19 16:51:45 2006
New Revision: 387091

URL: http://svn.apache.org/viewcvs?rev=387091&view=rev
Log:
While I'm at it, remove all of the bogus default settings.

If the ProtocolHandler doesn't set these, then it's a bug that should be fixed.  AFAIK, all
Tomcat-supplied ProtocolHandlers work just fine, so there should be no functional change with
a default install.

Modified:
    tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Request.java

Modified: tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Request.java
URL: http://svn.apache.org/viewcvs/tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Request.java?rev=387091&r1=387090&r2=387091&view=diff
==============================================================================
--- tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Request.java (original)
+++ tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Request.java Sun Mar 19 16:51:45
2006
@@ -74,10 +74,6 @@
         parameters.setURLDecoder(urlDecoder);
         parameters.setHeaders(headers);
 
-        methodMB.setString("GET");
-        uriMB.setString("/");
-        protoMB.setString("HTTP/1.0");
-
     }
 
 
@@ -478,16 +474,8 @@
         queryMB.recycle();
         methodMB.recycle();
         protoMB.recycle();
-        //remoteAddrMB.recycle();
-        //remoteHostMB.recycle();
 
-        // XXX Do we need such defaults ?
         schemeMB.recycle();
-        methodMB.setString("GET");
-        uriMB.setString("/");
-        protoMB.setString("HTTP/1.0");
-        //remoteAddrMB.setString("127.0.0.1");
-        //remoteHostMB.setString("localhost");
 
         instanceId.recycle();
         remoteUser.recycle();



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message