Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 60803 invoked from network); 13 Feb 2006 16:00:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Feb 2006 16:00:53 -0000 Received: (qmail 40166 invoked by uid 500); 13 Feb 2006 16:00:48 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 40122 invoked by uid 500); 13 Feb 2006 16:00:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 40111 invoked by uid 500); 13 Feb 2006 16:00:47 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 40106 invoked by uid 99); 13 Feb 2006 16:00:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2006 08:00:47 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 13 Feb 2006 08:00:47 -0800 Received: (qmail 60563 invoked by uid 65534); 13 Feb 2006 16:00:26 -0000 Message-ID: <20060213160026.60562.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r377402 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java Date: Mon, 13 Feb 2006 16:00:26 -0000 To: tomcat-dev@jakarta.apache.org From: fhanik@apache.org X-Mailer: svnmailer-1.0.6 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: fhanik Date: Mon Feb 13 08:00:24 2006 New Revision: 377402 URL: http://svn.apache.org/viewcvs?rev=377402&view=rev Log: Corrected logging of IOException, keep alive close will cause an IOException on the other end. Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java?rev=377402&r1=377401&r2=377402&view=diff ============================================================================== --- tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java (original) +++ tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java Mon Feb 13 08:00:24 2006 @@ -70,7 +70,14 @@ } catch (Exception e) { //this is common, since the sockets on the other //end expire after a certain time. - log.warn ("TCP Worker thread in cluster caught '" + e + "' closing channel", e); + if ( e instanceof IOException ) { + //dont spew out stack traces for IO exceptions unless debug is enabled. + if (log.isDebugEnabled()) log.debug ("IOException in replication worker, unable to drain channel. Probable cause: Keep alive socket closed.", e); + else log.warn ("IOException in replication worker, unable to drain channel. Probable cause: Keep alive socket closed."); + } else if ( log.isErrorEnabled() ) { + //this is a real error, log it. + log.error("Exception caught in TcpReplicationThread.drainChannel.",e); + } // close channel and nudge selector try { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org