From dev-return-66726-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Tue Feb 28 22:31:41 2006 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 90257 invoked from network); 28 Feb 2006 22:31:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 28 Feb 2006 22:31:40 -0000 Received: (qmail 4025 invoked by uid 500); 28 Feb 2006 22:31:34 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 3957 invoked by uid 500); 28 Feb 2006 22:31:34 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 3943 invoked by uid 99); 28 Feb 2006 22:31:34 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2006 14:31:34 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of costin@gmail.com designates 64.233.184.198 as permitted sender) Received: from [64.233.184.198] (HELO wproxy.gmail.com) (64.233.184.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2006 14:31:25 -0800 Received: by wproxy.gmail.com with SMTP id i23so1218461wra for ; Tue, 28 Feb 2006 14:31:05 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Tg/p3jpLvK8vPlT2OV8MrWdW1PaCHQ/qZJM6yCCU7jDpPDj2DewZ6LUGKpQg6bHZBZc2Q/+KTYP9zRBySvYDVZGo9rbRfDKf2N/UieCqHHwm0pZ/1tYzba8wsLPg51t4c18Trelb+qfsnxBeL5ZfJNcZVfqAi9ADpoVuW/qYtto= Received: by 10.65.74.12 with SMTP id b12mr1553530qbl; Tue, 28 Feb 2006 14:31:04 -0800 (PST) Received: by 10.65.15.15 with HTTP; Tue, 28 Feb 2006 14:31:04 -0800 (PST) Message-ID: <96e4b5230602281431v15ea1a2bl1869e30e3e827705@mail.gmail.com> Date: Tue, 28 Feb 2006 14:31:04 -0800 From: "Costin Manolache" Reply-To: costin@apache.org To: "Tomcat Developers List" Subject: Re: Tomcat 6 source organisation In-Reply-To: <4404C9B0.8040608@hanik.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <44047528.9040708@apache.org> <4404B80B.3010100@apache.org> <96e4b5230602281351l71081d54w314228fc268fb449@mail.gmail.com> <4404C9B0.8040608@hanik.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Of course, this is a case where you need a separate module. IMHO it is a bad sign when you have to do this - maybe you could use a different package name instead of same class names, or refactor a bit so you don't de= pend on the class name. But if for any reason you have to use the same classname, then use a different module for that code. JDK does this for platform-specific things in IO, awt, etc. I think this should be the exception, not the rule. Costin On 2/28/06, Filip Hanik - Dev Lists wrote: > I would prefer to keep the module source tree separate. > For example, the "ha" module (cluster2) uses the same classes as the > "cluster", but they are being enhanced for performance and modularity. > merging all this into one tree would be a pain in the neck. > > Filip > > > Costin Manolache wrote: > > On 2/28/06, Mark Thomas wrote: > > > >> Remy Maucherat wrote: > >> > >>> Hi, > >>> > >>> I think it is time to decide how the source repository is going to be > >>> organized, with the questions being: > >>> - how many source folders do we need (Costin wanted one, while others > >>> like Jacob seem to want "modules") ? > >>> - do we continue to use Ant ? > >>> - etc > >>> > >> I am +0 on any changes. > >> > >> Assuming some changes are made, there needs to be some thought given > >> to where in the source tree we put the trunk/branch/tag structure > >> before we start moving things around. > >> > > > > > > Well, single source tree means all source will be in one svn repo. > > > > My understanding is that you can label/tag/branch subdirs - and that a > > tag is cheap enough that you can do it for the entire tree. > > > > I think it's better to tag the entire tree - not just the component, > > so it's easier to reproduce ( since it has deps, etc ). That seems the > > current practice. > > > > > > > > > > > > > > > >> There have also been various comments made that different components > >> may be released on different release cycles. If this route is > >> followed, there needs to be a reasonably clear idea of what these > >> components might be as this will also have an impact on the best way > >> to structure the source. > >> > >> > > > > I don't think the source structure should be related to release structu= re. > > > > >From one source tree you can generate as many jars and packages as you > > want, in any structure or variation. > > > > Things like 'el' or 'jspc' or maybe cluster could chose to release - > > either as a jar, or as a .tar.gz or anything else. Or maybe not - that > > should be an independent decision from source tree layout or build > > mechanism. > > > > Costin > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > > For additional commands, e-mail: dev-help@tomcat.apache.org > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org