tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <>
Subject Re: This commit needs a review (WAS: svn commit: r375077 - in /tomcat/connectors/trunk/jk: native/iis/jk_isapi_plugin.c xdocs/changelog.xml)
Date Mon, 06 Feb 2006 13:49:14 GMT

On Feb 5, 2006, at 2:03 PM, Mark Thomas wrote:

> My C is very rusty. I *think* this is OK and doesn't do anything
> dangerous but I would be grateful if someone could review it.

It looks like this just handles the case where pfc->pFilterContext
isn't NULL, which means memory has already been allocated for
it. As such, except for the allocation in the if-part,
the logic should flow the exact same way, so +1

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message