tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Rossbach ...@objektpark.de>
Subject tomcat 5.5 Cluster and JMX
Date Thu, 23 Feb 2006 08:57:46 GMT
Hey Filip

Why do you think we must move the cluster JMX MBean code?
OK, then we can use the cluster components without JMX, but is this  
really usefull?
A lot of my customers have add there own monitoring to the current  
cluster MBeans.
This is really important to see trends and analyse bad szenarios at  
production level.

The most tomcat components have no separate MBean classes. When we  
move to separate classes we get
a lot of classes with redundant get/setter attributes and operation  
signatures.
Here the only chance to guarantee consistens is generation of the  
associated MBeans.
The reasons
behind I added the JMX code direclty into the cluser component   
implementation are:
- The clustet component controls the JMX
capabilities
- When we move the mbean code out, we need a factory to create  
cluster components
and the associate MBeans.
- Start the cluster without JMX should be not an option
- The dynamic lifecycle of cluster senders is not easy to manage
- Digester class creation is another point.
- Easy to implement and to hold consistent with other tomcat components
  	
OK, I also do not love the "backed" JMX code , but before moving we  
should discuss this point!!!

regards
Peter



Am 22.02.2006 um 23:57 schrieb fhanik@apache.org:

> Author: fhanik
> Date: Wed Feb 22 14:57:35 2006
> New Revision: 379956
>
> URL: http://svn.apache.org/viewcvs?rev=379956&view=rev
> Log:
> supressing JMX errors for now, since the code will be moved to JMX  
> monitor beans
>
> Modified:
>     tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
> catalina/cluster/tcp/ReplicationTransmitter.java
>
> Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/ 
> apache/catalina/cluster/tcp/ReplicationTransmitter.java
> URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/ 
> cluster/src/share/org/apache/catalina/cluster/tcp/ 
> ReplicationTransmitter.java?rev=379956&r1=379955&r2=379956&view=diff
> ====================================================================== 
> ========
> --- tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
> catalina/cluster/tcp/ReplicationTransmitter.java (original)
> +++ tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
> catalina/cluster/tcp/ReplicationTransmitter.java Wed Feb 22  
> 14:57:35 2006
> @@ -714,7 +714,7 @@
>                  mserver.unregisterMBean(getSenderObjectName(sender));
>              }
>          } catch (Exception e) {
> -            log.warn(e);
> +            if ( log.isDebugEnabled() ) log.debug 
> ("'ReplicationTransmitter' Unable to to deregister IDataSender",e);
>          }
>      }
>
> @@ -738,7 +738,7 @@
>                  mserver.registerMBean(cluster.getManagedBean(sender),
>                          senderName);
>              } catch (Exception e) {
> -                log.warn(e);
> +                if ( log.isDebugEnabled() ) log.debug 
> ("'ReplicationTransmitter' Unable to register sender bean",e);
>              }
>          }
>      }
> @@ -764,7 +764,7 @@
>                      + sender.getAddress().getHostAddress() +  
> ",senderPort="
>                      + sender.getPort());
>          } catch (Exception e) {
> -            log.warn(e);
> +            if ( log.isDebugEnabled() ) log.debug 
> ("'ReplicationTransmitter' Unable to retrieve sender name",e);
>          }
>          return senderName;
>      }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message