tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Sexton" <gsex...@mhsoftware.com>
Subject RE: never say never...
Date Mon, 20 Feb 2006 23:10:49 GMT

> -----Original Message-----
> From: Mark Thomas [mailto:markt@apache.org] 
> Sent: Monday, February 20, 2006 4:02 PM
> To: Tomcat Developers List
> Subject: Re: never say never...
> 
> George Sexton wrote:
> Whilst I agree with the general thrust of the arguments made so far in
> this thread I do take serious issue with one of your statements.
> 
> > Just as a little example, several months ago I submitted a 
> patch. One
> > committer commented that he would -1 it for the "com.sun" 
> imports. There
> > weren't any com.sun imports, and when called on it the 
> committer just gaffed
> > me off.
> This is not an accurate representation of the facts. The thread can be
> read here:
> http://marc.theaimsgroup.com/?l=tomcat-dev&r=1&s=allowedAliasM
> atches&q=b&w=4
> 
> The commit Bill was referring to is this one:
> http://marc.theaimsgroup.com/?l=tomcat-dev&m=111788844800136&w=4
> that includes
> +import com.sun.org.apache.bcel.internal.generic.ALOAD;
> 
> Bill did not "gaff you off". He pointed out he was -1 for the commit
> on the basis of the import. He also expanded on other areas he had
> concerns over.
> 
>  So, this committer just flat out lied (or was mistaken and when
> > corrected denied the original error)
> Accusing someone of lying is a serious allegation and on the basis of
> the dev archive clearly not true in this case. I would urge you to
> retract your comment.

I stand corrected. The referenced import must have been added by Peter
Rossbach when he committed it. My submitted code did not have the com.sun
import. This is why I didn't think it was there. When the comment was made,
I reviewed my submission and didn't see it.

George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
  


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message