Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of costin@gmail.com designates
 64.233.162.193 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ceLhqdzkYtzzrZ3AB5jZ3ku2UE+b3GL2eyXOgnQCza3AjJs7ybtYMnfRw18tmY8qAtXQqD0TUDs/s5WonDmn/BLuksvK7iBtL1E07aFmIunJj36xTL/mHMKuLi3CrrOek5fe0GUFmQn8xcVq8/htuqOtMCZMXrRHmrQvSELS3PA=
Message-ID: <96e4b5230601091159x5d8a77aax4aa06a48965434cb@mail.gmail.com>
Date: Mon, 9 Jan 2006 11:59:48 -0800
From: Costin Manolache <costin@gmail.com>
Reply-To: costin@apache.org
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r367115 -
 /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java
In-Reply-To: <43C2BA1D.3080207@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <20060108224846.69409.qmail@minotaur.apache.org>
	 <43C28B35.2050909@apache.org> <43C2BA1D.3080207@apache.org>

If you're looking to reduce complexity - one idea would be to check if
the redundant fields are actually needed, because that's the actual
source of the problem.

I can only think of performance benefits - storing the contentLength
as an int may be a good way to avoid conversion to and from String -
but the headers are stored as MessageBytes, and that supports storing
the int value. If the redundant values are used to avoid looking up
the header - storing the MessageBytes value could solve this.

If you decide to fix it at the higher layer - maybe you can also
deprecate the method containsHeader in Response or put a big javadoc
saying that it's not very accurate.


Costin

On 1/9/06, Mark Thomas <markt@apache.org> wrote:
> Remy Maucherat wrote:
> > markt@apache.org wrote:
> >> Fix bug 29214. containsHeader() not working for Content-Length and
> >> Content-Type
> >
> > Rather than adding complexity in code which is critical, I would have
> > hacked instead the org.apache.catalina.connector.Response.containsHeade=
r
> > method, which is not actually used at all (except by application code,
> > IMO for weird reasons).
>
> I'll look into an alternative patch that has less impact on the
> critical code.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org