tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cos...@gmail.com>
Subject Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml
Date Wed, 11 Jan 2006 01:36:54 GMT
I guess the better solutions are to either deal with this in the
servlet facade ( i.e. the HttpServletResponse impl ) - or to just
remove the cached fields from coyote Response.

The second is harder - but the right one IMO, it's bad to have methods
in Response that don't do what people would expect them to do and
workaround in facade to deal with complexity. And we already have a
cache ( for converted int values ) in MessageBytes.

I'm sure Remy would be happier with the first solution, and it's
simpler to implement. But I agree that we shouldn't add this to
Response.

Costin


On 1/10/06, Remy Maucherat <remm@apache.org> wrote:
> markt@apache.org wrote:
> > Author: markt
> > Date: Tue Jan 10 15:06:22 2006
> > New Revision: 367826
> >
> > URL: http://svn.apache.org/viewcvs?rev=367826&view=rev
> > Log:
> > Alternative patch for bug 29214 based on Remy's comments
>
> I didn't have time to look into it much, but I would have thought using
> coyoteResponse.getContentLength() != -1 would be more good enough.
> Otherwise, the code isn't really that much simpler.
>
> Rémy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message