tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-frederic Clere <jfcl...@telefonica.net>
Subject Re: AprEndpoint and IPv6
Date Sun, 29 Jan 2006 10:07:39 GMT
Jim Jagielski wrote:

> There's a bug report (37788) regarding allowing AprEndpoint
> to use APR IPv6 addresses. Their patch is almost right, but
> instead the value should be to use APR_UNSPEC instead
> of APR_INET6 (or the current APR_INET) to allow APR
> to correctly determine IP version and do a graceful
> recovery... As well as handle cases where APR wasn't
> built with IPv6 support.
>
> I'd like to commit that change... comments?

Looking to src/network.c, I have noted:
+++
    if (family > 0) {
        TCN_THROW_IF_ERR(apr_socket_create(&s,
                         f, t, protocol, p), a);
    }
+++
Isn't APR_UNSPEC defined to zero? - that would explain the problem 
decribed in
http://issues.apache.org/bugzilla/attachment.cgi?id=17525 -

Cheers

Jean-Frederic

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message