tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml
Date Wed, 11 Jan 2006 07:26:08 GMT
Remy Maucherat wrote:
> markt@apache.org wrote:
> 
>> Author: markt
>> Date: Tue Jan 10 15:06:22 2006
>> New Revision: 367826
>>
>> URL: http://svn.apache.org/viewcvs?rev=367826&view=rev
>> Log:
>> Alternative patch for bug 29214 based on Remy's comments
> 
> 
> I didn't have time to look into it much, but I would have thought using
> coyoteResponse.getContentLength() != -1 would be more good enough.
> Otherwise, the code isn't really that much simpler.

I thought about doing it that way but I wanted to catch the difference
between Content-Length defaulting to -1 and the page developer
explicitly setting it to -1. It is an edge case I admit but I don't
see any harm in covering it given where the implementation now sits.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message