tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cos...@gmail.com>
Subject Re: Improving memory efficiency
Date Sun, 18 Dec 2005 18:01:08 GMT
One of the problems is that jasper is a tricky piece of code, and
usually reducing memory this way can have unexpected impact. Maybe a
more 'moderate' approach would be more acceptable, like checking the
size of the buffers, and only reset it if it is indeed 'huge'. This
would take care of the worse case, yet still allow keeping the buffers
around for normal use.

Don't know what testing you did  (to evaluate the performance impact
of the change), but try with a very large number of concurent
requests. That's where avoiding buffer allocations is most visible,
Remy spent a lot of time making sure no buffer is allocated in the
critical path under load.


Costin



On 12/18/05, Tino Schwarze <tino.schwarze@tisc.de> wrote:
> On Sun, Dec 18, 2005 at 05:02:39PM +0100, Remy Maucherat wrote:
>
> > >What do you think about this issue?
> >
> > It's a fine solution for your "problem", I suppose. Thanks for the
> > patch, but we are not going to use it.
>
> So could you please give me a hint, why you are not going to use it? My
> "problem" is a real PROBLEM in production environments. There are
> Tomcat's starving with OutOfMemoryErrors. What would be your approach to
> solving this (apart from "give tomcat more memory")?
>
> Bye+Thanks!
>
> Tino.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message