tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Speed <psp...@progeeks.com>
Subject Re: svn commit: r358285 - in /tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime: BodyContentImpl.java JspFactoryImpl.java
Date Wed, 21 Dec 2005 17:41:48 GMT
Just wondering if/why this is better than simply calling:
Boolean.getBoolean( 
"org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER" );

All of them end up calling the same method anyway, but getBoolean() 
seems clearer to me in this case and was just wondering if there is 
something bad about it.

-Paul

remm@apache.org wrote:

> Author: remm
> Date: Wed Dec 21 05:09:42 2005
> New Revision: 358285
> 
> URL: http://svn.apache.org/viewcvs?rev=358285&view=rev
> Log:
> - Ok, so I used a Java 5 API.
> 
> Modified:
>     tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
>     tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
> 
> Modified: tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
> URL: http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java?rev=358285&r1=358284&r2=358285&view=diff
> ==============================================================================
> --- tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
(original)
> +++ tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/BodyContentImpl.java
Wed Dec 21 05:09:42 2005
> @@ -41,7 +41,7 @@
>      private static final String LINE_SEPARATOR = 
>          System.getProperty("line.separator");
>      private static final boolean LIMIT_BUFFER = 
> -        Boolean.parseBoolean(System.getProperty("org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER",
"false"));
> +        Boolean.valueOf(System.getProperty("org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER",
"false")).booleanValue();
>      
>      private char[] cb;
>      private int nextChar;
> 
> Modified: tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
> URL: http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java?rev=358285&r1=358284&r2=358285&view=diff
> ==============================================================================
> --- tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
(original)
> +++ tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/runtime/JspFactoryImpl.java
Wed Dec 21 05:09:42 2005
> @@ -41,7 +41,7 @@
>  
>      private static final String SPEC_VERSION = "2.0";
>      private static final boolean USE_POOL = 
> -        Boolean.parseBoolean(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.USE_POOL",
"true"));
> +        Boolean.valueOf(System.getProperty("org.apache.jasper.runtime.JspFactoryImpl.USE_POOL",
"true")).booleanValue();
>  
>      private SimplePool pool = new SimplePool(100);
>      
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message