tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From billbar...@apache.org
Subject svn commit: r357143 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
Date Fri, 16 Dec 2005 08:13:26 GMT
Author: billbarker
Date: Fri Dec 16 00:13:19 2005
New Revision: 357143

URL: http://svn.apache.org/viewcvs?rev=357143&view=rev
Log:
Don't ask for authentication if deny-from-all is in effect.

I knew that there was a good reason that I hated aaa ;-).

Fix for Bug #37934


Modified:
    tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java

Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=357143&r1=357142&r2=357143&view=diff
==============================================================================
--- tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
(original)
+++ tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
Fri Dec 16 00:13:19 2005
@@ -475,7 +475,12 @@
         for(i=0; i < constraints.length && authRequired; i++) {
             if(!constraints[i].getAuthConstraint()) {
                 authRequired = false;
-            } 
+            } else if(!constraints[i].getAllRoles()) {
+                String [] roles = constraints[i].findAuthRoles();
+                if(roles == null || roles.length == 0) {
+                    authRequired = false;
+                }
+            }
         }
              
         if(authRequired) {  



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message