tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael H. Schloming" <rafa...@redhat.com>
Subject Re: directory listings
Date Thu, 01 Dec 2005 18:34:28 GMT
Thanks for the feedback. I'll make the changes you suggest as soon as I
have a chance and repost the patch.

On Wed, 2005-11-30 at 19:47 -0500, Yoav Shapira wrote:
> Hi,
> It's an interesting patch and an interesting idea in general.  I'm
> impressed with the performance findings, although I haven't seen
> anyone recently complaining about many concurrent directory listings
> requests.
> 
> I have a couple of requests for the patch, if you don't mind some
> feedback.  I'd prefer a separate class for the DirectoryListingCache
> or whatever you want to call it, with its CacheEntry and rendering,
> encoding methods.  It's kind of ugly to throw all of that into
> DefaultServlet.  DefaultServlet can then use the cache class.  I'd
> also prefer the relevant parameters (5, 1000) to be configurable, at
> least via protected setter/getter methods.  Finally, assuming the
> above refactoring is done, I'd like a parameter from web.xml to
> DefaultServlet setting whether to use the directory listing cache or
> not.  That way people can turn it off easily.
> 
> Yoav

-- 
Rafael H. Schloming <rafaels@redhat.com>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message