tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37262] - JDBC datasources are never released
Date Thu, 27 Oct 2005 14:42:56 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37262>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37262





------- Additional Comments From glenmazza@yahoo.com  2005-10-27 16:42 -------
(In reply to comment #3)
> No, we will not add proprietary code to release any resource provider resources
> (obviously, almost every resource provider will need something ...), but rather
> it is up to it to have its cleanup code. DBCP can do this by closing inactive
> connections, and everything should eventually be GCed.
> 
> Obviously, feel free to use your own custom code as needed.

Remy, 

I would agree that there would be a big can of worms here if Tomcat needed to
import:
+import com.mycompany.MyResource;
+import com.acme.MyBasicDataSource;

etc., etc., non-integrated resources, just to keep manually closing each
resource--there would be no end to it.

But looking at the import statement needed for this patch:
+import org.apache.--->tomcat<---.dbcp.dbcp.BasicDataSource;

It seems that DBCP has already been specifically integrated within
Tomcat[1]--i.e., the proprietary code is already there--and for that reason,
Tomcat should perhaps take care of DBCP cleanup needs.

OTOH, is there a bug with the implementation of DBCP that is not causing these
connections to close on its own--i.e., insufficient timeouts or other
enhancements that DBCP can (rightfully?) provide that will not require any
changes to Tomcat?  Maybe a patch should be submitted to DBCP instead.

Also, slightly different topic, needing to modify and rebuild Tomcat in order to
close proprietary resource providers seems nonideal.  Is there a cleaner way
within the servlet specification that this can be done without needing to recode
& rebuild Tomcat?  Just asking as a newbie here--I'm hardly a Tomcat/servlet expert.

Thanks,
Glen

[1] http://tinyurl.com/7ebqn


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message