tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)
Date Thu, 22 Sep 2005 15:32:58 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33453>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


jleech@virtela.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |




------- Additional Comments From jleech@virtela.net  2005-09-22 17:32 -------
Remy,
With all due respect I did read the report fully and I believe the
recommendation I made addressed comment #6.  If you feel my recommendation isn't
sufficient, please state why.
The other point in my first comment was that this bug can manifest itself in
ways more common than the original report, in fact that's why my colleague and I
found it.  
I have patched and tested my local Tomcat, and am attaching the two files I
modified for review.

(In reply to comment #10)
> (In reply to comment #9)
> > The .jsp file date stamp doesn't have to go back in time for the isOutDated
> > check to fail, it can and does fail in a more normal usage pattern.
> > Here is a scenario that shows the problem:
> > - I deploy version 1, the .jsp has time1
> > - I make version 2 of the .jsp at time2
> > - Visitor visits the site, and the .jsp is compiled at time3
> > - I deploy version2
> > - isOutDated returns false as time3 > time2
> > 
> > Would setting the date stamp of the .java and .class files to the date stamp of
> > the .jsp file, and changing the comparison from < to != in the isOutDated check
> > fix the problem sufficiently?  Or are there negative side effects I haven't
> > thought of?
> > 
> > I am working on patching my Tomcat to do exactly as above, I would be happy to
> > give it to someone for evaluation when its ready.  
> 
> As looked into in comment #6, this is not doable easily, which makes the few use
> cases which could benefit from this not worth it. Please try to read the report
> next time.
> 



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message