tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 36541] - session getAttribute/setAttribute and removeAttribute are NOT Thread safe.
Date Wed, 07 Sep 2005 16:45:49 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36541>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36541





------- Additional Comments From remm@apache.org  2005-09-07 18:45 -------
(In reply to comment #7)
> I would agree that neither implementation is buggy -- it is entirely legal for a
> servlet container to avoid letting an application corrupt its interna data
> structures.  It's too bad that the current Tomcat developers care more about
> performance than they care about reliability.

Of course. Thankfully, you guys have glassfish now for good reliability, so you
don't have to deal with these loony Tomcat developers anymore ;)

> If you aren't going to change it back to the 4.1 implementation (with
> synchronization locks around the accesses), please take my name out of the
> @author tag for org.apache.catalina.session.StandardSession -- this code does
> *not* represent anything I wish to be associated with.

Sure, I have no problem with that if it's your wish.

These changes were made as an experiment (the spec allows this to be
non-synced), and included in 5.0.19+ and as a consequence in all the most
popular 5.0.x releases. In the end, it would seem it worked reasonably well.
However, I did get a few reports of corruption a while after this, and I added
back synchrnozation on write operations to the map in the 5.5 branch. I never
ported this back to 5.0.x given the lack of demand. Apparently, you didn't look
at it.

All that got discussed in the past, including the readding of some of the syncs.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message