tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: Small refactoring in Http11Processor
Date Fri, 09 Sep 2005 18:27:13 GMT

----- Original Message -----
From: "Costin Manolache" <cmanolache@yahoo.com>
To: <tomcat-dev@jakarta.apache.org>
Sent: Thursday, September 08, 2005 10:56 PM
Subject: Small refactoring in Http11Processor


> Hi,
>
> I have a small patch, spliting the JMX-dependent code in
> Http11Processor, i.e.  the few lines of code dealing with the
> registration of the thread pool and per thread data - and moving all
> non-jmx code in a separate base class.
>
> I know Tomcat5 is heavily dependent on JMX, but the connector can be
> used in other containers, or it can be used standalone. This small
> change won't affect any functionality on tomcat - all methods are used
> only for intialization anyway, not in the critical path.
>
> Please review and let me know if it's ok to commit the change.
>

It seems that the only thing this patch does is to allow you to exclude
jmx.jar, so it's usefulness seems very minimal :).  TC 3.3 & 4.1 already run
very happily with the current code without JMX enabled.

Something better would be a refactor that would remove the duplicated code
between Http11Processor and Http11AprProcessor (which one doesn't do :).

Of course, none of this is enough for me to veto your scratching an itch :).

> Also, I would like to add another directory under j-t-c, with a build
> file and few classes for a 'mini' experiment - i.e. using the connector
> standalone, as a minimal http server, and also a target to build a
> minimal servlet container as a single self-contained jar. We don't have
> a sandbox, and j-t-c seems closest to that :-)
>

I agree with Mladen that this would work better if you could wait a couple
of weeks until we are up on SVN.

> Costin
>



This message is intended only for the use of the person(s) listed above as the intended recipient(s),
and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended
recipient, you may not read, copy, or distribute this message or any attachment. If you received
this communication in error, please notify us immediately by e-mail and then delete all copies
of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet
is not secure. Do not send confidential or sensitive information, such as social security
numbers, account numbers, personal identification numbers and passwords, to us via ordinary
(unencrypted) e-mail.


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message