tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-frederic Clere <jfcl...@telefonica.net>
Subject Re: mod_jk logging buffer
Date Fri, 12 Aug 2005 16:12:18 GMT
Radek Wierzbicki wrote:

> Hello,
>
> I see a problem with logging mechanism in mod_jk 1.2.14.1. The logger 
> buffers and delays the output of messages with levels below 'info' 
> (info, warning, error, emergency, request).
>
> With the new version, setting the log level to 'error' on production 
> setups will delay the output of critical error messages. I think that 
> is unacceptable.
>
> Wouldn't it make sense to reverse the logic and immediatelly flush the 
> log messages with level 'info' and below, and buffer 'debug' and 
> 'trace' messages?
>
> Maybe a configuration option for log buffering would make sense?
>
> Patch:
>
> --- jk_util.c.orig      2005-07-01 17:41:08.000000000 +0200
> +++ jk_util.c   2005-08-12 13:44:01.000000000 +0200
> @@ -186,7 +186,7 @@
>              fwrite(what, 1, sz, p->logfile);
>              fputc('\n', p->logfile);
>              /* [V] Flush the dam' thing! */
> -            if (l->level < JK_LOG_INFO_LEVEL)
> +            if (l->level > JK_LOG_DEBUG_LEVEL)
>                  fflush(p->logfile);
>          }
>
> ... awaiting comments ...

better :
if (l->level < JK_LOG_INFO_LEVEL || level==JK_LOG_EMERG || 
level==JK_LOG_ERROR)
No?

>
> -Radek W.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message