DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33650>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33650
------- Additional Comments From xbgao@cs.ucf.edu 2005-08-22 16:33 -------
(In reply to comment #30)
> As the current code only caches the result of the xml parsing it should
> translates in roughly a 30% speedup for Liferay compilation.
>
In my testcase with liferay source package (more specifically, all jsp files
under portal-web/docroot), I could get more than 30% speedup. I did a series of
experiments and the results were:
1. Dell Dimension 4600, 2.8GHz, 768M: time reduced from ~130s to ~65s.
2. one cluster node, AMD Athlon(tm) Processor, 908MHz, 768M: time reduced from
(12m + 50s) to (2m + 55s).
It depends on the machines but my cases show significant improvement.
> Liferay being static include happy, it is a good testcase as well. The xml
> parsing was the easy part :) As Remy mentions there is load of improvement in
> there as the JSP parsing is obviously not very efficient.
>
> As a side note, I'm nit-picking but I think it would be better to have a
> single method that returns the TreeNode. here I feel like they are 2 pieces of
> code related to 'is cache in use'.
>
> 1) getOptions().getCachedTldXmlMap() return the map or null
> 2) if (ctxt.getServletContext() instanceof
> org.apache.jasper.servlet.JspCServletContext) is used to figure out if it
> should look into the cache (why not checking if the map is null or not ?)
>
> I might be missing something, but this if is confusing me.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
|