Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <42A3395E.7070801@apache.org>
Date: Sun, 05 Jun 2005 19:41:50 +0200
From: Remy Maucherat <remm@apache.org>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper
 HostMap.java Mapper.java
References: <20050605155347.A54D4F12E@mail.mhsoftware.com>
In-Reply-To: <20050605155347.A54D4F12E@mail.mhsoftware.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

George Sexton wrote:
> There's no justification here. Explain why you think the code is "bad" it's
> actually a hell of a lot cleaner and easier to follow than the original
> code, and it's 15% faster. What exactly are your criteria for measuring
> goodness.

I stated the reason, and the main one is that it should I think be more 
generic. The performance improvement is just a lame trick to push 
through your feature, as this could as well be submitted as two separate 
patches (the first one being the optimizations, and the second one the 
wildcard host feature addition which I would -1).

"hell of a lot" just made me laugh, BTW ;)

R�my

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org