tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: cvs commit: jakarta-tomcat-connectors/jni/native configure.in
Date Thu, 23 Jun 2005 09:58:54 GMT
Mladen Turk wrote:
> William A. Rowe, Jr. wrote:
> 
>> At 02:01 AM 6/23/2005, Mladen Turk wrote:
>>
>>>
>>>> -        CFLAGS="${CFLAGS} -DDEBUG -Wall"
>>>> +        CFLAGS="${CFLAGS} -DDEBUG"
>>>
>>>
>>> I would prefer that you add some platform case/esac that will
>>> in ReliantUnix case add what ever you wish to the CFLAGS.
>>
>>
>>
>> Conversely, a compiler case/esac would avoid altogether breaking
>> AIX, HP/UX, Reliant and a dozen other oddballs.  Forcing users to
>> play cflags is really a symptom of a weak build system.
>>
> 
> Something simple like:
> 
>  ....
>    if test "$GCC" = "yes"; then
>      CFLAGS="${CFLAGS} -DDEBUG -Wall"
>    elif test "$AIX_XLC" = "yes"; then
>      CFLAGS="${CFLAGS} -DDEBUG -qfullpath -qinitauto=FE -qcheck=all"
>    elif test $MYCOMPILER = "yes"....; then
>      CFLAGS="${CFLAGS} -DDEBUG my what ever flags"
>    else
>      CFLAGS="${CFLAGS} -DDEBUG"
>    fi
> 
> Would do the trick ;)

Yep, even:
+++
  if test "$GCC" = "yes"; then
      CFLAGS="${CFLAGS} -DDEBUG -Wall"
  else
      CFLAGS="${CFLAGS} -DDEBUG"
  fi
+++
gets my +1.

> 
> Regards,
> Mladen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message