tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Sexton" <gsex...@mhsoftware.com>
Subject RE: Code Submission - Wild Card Aliases
Date Mon, 09 May 2005 02:49:18 GMT
OK, here is what I believe is the final version of the Mapper code with
support for wildcard matching.

The new code is approximately 14.7% faster, executing the 1,000,000
iteration test loop in 7480 ms versus 8772.5 ms for the original code, a
difference of 1292.5 ms. Times were computed by executing the main()
function 10 times, and recording the results. The median value was then
calculated and used for reporting. For those interested, the times for the
tests are below.

Here are the files:

HostMap.java - New File to act as a container for hosts. It contains
searching methods to find hosts.
http://www.mhsoftware.com/~gsexton/HostMap.java

Mapper.diff - Diff between 5.5.9 mapper and the current one. Because of the
abstraction of the host mapping into a new class it's not super useful, but
included for completeness.
http://www.mhsoftware.com/~gsexton/Mapper.diff

Mapper.java - Complete, modified Mapper.java file.
http://www.mhsoftware.com/~gsexton/Mapper.java

Harness_output.diff - Difference between the test harness output using the
5.5.9 code, and the modified code.
http://www.mhsoftware.com/~gsexton/harness_output.diff


Once I sort out the correct method of setting the default # of Alias
Matches, I will submit the complete set as a diff. Unless someone else want
to do the parameter setting. Right now the default # of alias matches is
hard-wired to 16.

Some people have asked me to integrate the test harness into a Junit testing
module. Unfortunately, I don't have any experience w/ Junit, so I don't
think I would be a good candidate for this.

There's one final thing. During previous discussions, it was kind of hinted
I should put the alias match limiting in the Connector. It seems kind of
ugly since this seems to apply at the host or alias level. Does anyone have
thoughts on this?

For testing purposes, a P3 600 Mhz running SUSE Linux 9.2, w/ JDK
1.4.2_06-b03 was used.

New Code

7477ms
7641ms
7692ms
7394ms
7395ms
7475ms
7527ms
7482ms
7480ms
7480ms

Median:  7480ms

5.5.9 Mapper w/ New Test Harness

8561ms
8560ms
8771ms
8774ms
8771ms
8767ms
8860ms
8775ms
8775ms
8782ms

Median: 8772.5ms

George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
  

> -----Original Message-----
> From: Peter Rossbach [mailto:pr@objektpark.de] 
> Sent: Thursday, May 05, 2005 8:40 AM
> To: Tomcat Developers List
> Subject: Re: Code Submission - Wild Card Aliases
> 
> Great news,
> 
> can you post your new code that we can test it also?
> 
> Many thanks
> Peter
> 
> George Sexton schrieb:
> 
> >The measurement was calculated by taking the median reading of 10
> >consecutive executions.
> >
> >Just for your edification they were:
> >
> >New Code:
> >
> >7373ms
> >7395ms
> >7383ms
> >7370ms
> >7384ms
> >7385ms
> >7395ms
> >7376ms
> >7378ms
> >7393ms
> >
> >Median: 7383.5ms
> >
> >
> >Old code:
> >
> >8561ms
> >8560ms
> >8771ms
> >8774ms
> >8771ms
> >8767ms
> >8860ms
> >8775ms
> >8775ms
> >8782ms
> >
> >Median: 8772.5ms
> >
> >Difference: 1389ms ~ 15.8% improved
> >
> >My mistake for not wanting to bore the list with minutiae.
> >
> >George Sexton
> >MH Software, Inc.
> >http://www.mhsoftware.com/
> >Voice: 303 438 9585
> >  
> >
> >  
> >
> >>-----Original Message-----
> >>    
> >>
> >
> >  
> >
> >>The original code you submitted looks quite bad so I don't 
> trust your 
> >>measurements at all, sorry.
> >>
> >>Rémy
> >>
> >>------------------------------------------------------------
> ---------
> >>To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >>
> >>
> >>    
> >>
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
> >
> >
> >
> >  
> >
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message