tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
Date Wed, 11 May 2005 22:43:41 GMT

----- Original Message -----
From: <markt@apache.org>
To: <jakarta-tomcat-catalina-cvs@apache.org>
Sent: Wednesday, May 11, 2005 2:39 PM
Subject: cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml


> markt       2005/05/11 14:39:41
>
>   +            // Restore body
>   +            InputFilter savedBody = new SavedRequestInputFilter(body);
>   +            InternalInputBuffer internalBuffer = (InternalInputBuffer)
>   +                request.getCoyoteRequest().getInputBuffer();
>   +            internalBuffer.addActiveFilter(savedBody);

This is going to crash-and-burn spectacularly for anybody using the AJP/1.3
Connector.

>   +
>   +            byte[] buffer = new byte[4096];
>   +            int bytesRead;
>   +            InputStream is = request.getInputStream();
>   +            ByteChunk body = new ByteChunk();
>   +
>   +            while ( (bytesRead = is.read(buffer) ) >= 0) {
>   +                body.append(buffer, 0, bytesRead);
>   +            }
>   +            saved.setBody(body);
>            }

It's generally not a good idea to allow unlimited saving of POST data, since
I can bring down your server by simply POSTing a 4GB file to a protected
page.



This message is intended only for the use of the person(s) listed above as the intended recipient(s),
and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended
recipient, you may not read, copy, or distribute this message or any attachment. If you received
this communication in error, please notify us immediately by e-mail and then delete all copies
of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet
is not secure. Do not send confidential or sensitive information, such as social security
numbers, account numbers, personal identification numbers and passwords, to us via ordinary
(unencrypted) e-mail.



Mime
View raw message