tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 34652] New: - JspC does not support Smap generation
Date Wed, 27 Apr 2005 19:11:20 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34652>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34652

           Summary: JspC does not support Smap generation
           Product: Tomcat 5
           Version: Nightly Build
          Platform: All
        OS/Version: Windows XP
            Status: NEW
          Keywords: PatchAvailable
          Severity: normal
          Priority: P2
         Component: Jasper
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: daryl.robbins@mxi.com


The values for the supressSmap and dumpSmap options are hard coded. This makes
it impossible to include line mapping information when precompiling a JSP. The
included patch should resolve this issue.

--- JspC.java.orig	Tue Mar 29 17:43:37 2005
+++ JspC.java	Wed Apr 27 14:50:21 2005
@@ -114,6 +114,8 @@
     private static final String SWITCH_DIE = "-die";
     private static final String SWITCH_POOLING = "-poolingEnabled";
     private static final String SWITCH_ENCODING = "-javaEncoding";
+    private static final String SWITCH_SMAP = "-smap";
+    private static final String SWITCH_DUMP_SMAP = "-dumpsmap";
 
     private static final String SHOW_SUCCESS ="-s";
     private static final String LIST_ERRORS = "-l";
@@ -147,6 +149,8 @@
     private int dieLevel;
     private boolean helpNeeded = false;
     private boolean compile = false;
+    private boolean supressSmap = true;
+    private boolean dumpSmap = false;
 
     private String compiler = null;
 
@@ -293,6 +297,10 @@
                 setCompilerSourceVM(nextArg());
             } else if (tok.equals(SWITCH_TARGET)) {
                 setCompilerTargetVM(nextArg());
+            } else if (tok.equals(SWITCH_SMAP)) {
+                supressSmap = false;
+            } else if (tok.equals(SWITCH_DUMP_SMAP)) {
+                dumpSmap = true;
             } else {
                 if (tok.startsWith("-")) {
                     throw new JasperException("Unrecognized option: " + tok +
@@ -406,14 +414,14 @@
      * Is the generation of SMAP info for JSR45 debuggin suppressed?
      */
     public boolean isSmapSuppressed() {
-        return true;
+        return supressSmap;
     }
 
     /**
      * Should SMAP info for JSR45 debugging be dumped to a file?
      */
     public boolean isSmapDumped() {
-        return false;
+        return dumpSmap;
     }
 
     /**

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message