tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: Tagging JK 1.2.9 on 3/17/2005
Date Thu, 17 Mar 2005 19:37:58 GMT
Rainer Jung wrote:
> Concerning socket_timeout:
> 
> 1) In common/jk_connect.c there is a typo:
> 
>    374          setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO,
>    375                     (const void *) &tv, sizeof(tv));
>    376          setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO,
>    377                     (const void *) &tv, sizeof(tv));
> 
> so both setsockopts use the same option. It should be SO_SNDTIMEO in line
> 376. Maybe that's easy enough to change for 1.2.9.
> 

Yes, it should be SO_SNDTIMEO. Seems like typo :).


> 2) The test in configure about functionality of the timeouts is broken.
> The test program does not compile under Solaris, because it needs
> "-lsocket".
>

Can you provide a patch for that?

> 
> When I compile the test program with "-lsocket" it compiles but it exits
> as expected with "1". So under Solaris the two timeouts are defined in the
> include files, but they do not work with setsockopt. Since this doesn't
> change the result in the end, it might also be corrected after 1.2.9.
>

Sure, that's the purpose of JK_CHECK_SETSOCKOPT function.


Regards,
Mladen.




---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message