tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ValveBase.java
Date Wed, 02 Mar 2005 01:30:53 GMT
luehe@apache.org wrote:
> luehe       2005/02/23 11:27:56
> 
>   Modified:    catalina/src/share/org/apache/catalina/authenticator
>                         FormAuthenticator.java NonLoginAuthenticator.java
>                         SSLAuthenticator.java SingleSignOn.java
>                catalina/src/share/org/apache/catalina/realm
>                         DataSourceRealm.java JDBCRealm.java JNDIRealm.java
>                         RealmBase.java UserDatabaseRealm.java
>                catalina/src/share/org/apache/catalina/valves ValveBase.java
>   Log:
>   No change in functionality.
>   
>   Added new "containerLog" instance var to RealmBase and ValveBase, which is
>   initialized as "container.getLogger()" inside setContainer().
>   
>   This will make it easier to do something like
>   
>     containerLog = LogFactory.getLog(container.logName()+".RealmBase");
>   
>   in the future, as suggested by Bill Barker.

Actually, this is probably a bad idea (or at least the implementation is 
bad): the logger must be retrieved only when the context class loader of 
the application is set. This means no retrieving the logger in 
ValveBase.setContainer, since this is first called in StandardContext().

Rémy (who's having a lot of fun with logging at the moment)

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message