tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm JDBCRealm.java
Date Wed, 09 Mar 2005 00:01:11 GMT

----- Original Message -----
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Tuesday, March 08, 2005 3:46 PM
Subject: Re: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm
JDBCRealm.java


>Bill Barker wrote:
>>>remm        2005/03/08 15:03:01
>>>
>>>  Modified:    catalina/src/share/org/apache/catalina/realm
JDBCRealm.java
>>>  Log:
>>>  - Add back the reconnection logic to JDBC realm, which was removed for
>>
>> wrong reasons. From what I saw, it causes major issues with MySQL
otherwise
>>
>>>    (obviously, another solution is to use the better data source realm).
>>
>> <snip />
>>
>>>  +                open();
>>>  +
>>>                   try {
>>>  +                    stmt = credentials(dbConnection, username);
>>>  +                    rs = stmt.executeQuery();
>>>  +
>>>  +                    if (rs.next()) {
>>>  +                        dbCredentials = rs.getString(1);
>>>  +                    }
>>>                       rs.close();
>>
>>
>> Either I'm really missing something, or you need a break statement here.
>> Otherwise it always runs twice, even if the first time succeeded.
>
>Thanks for reading the code, we need to catch regressions and problems
>more efficiently (we managed to caused major regressions in BOTH
>database realms in 5.5.7, which is completely unacceptable). In this
>case, there's a "return" inside the loop, so I assume it would be ok.
>

Yup I was really missing something (like the '-' in front of the '}
catch...' :).

>BTW, I did not test the code at all.
>
>Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org





This message is intended only for the use of the person(s) listed above as the intended recipient(s),
and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended
recipient, you may not read, copy, or distribute this message or any attachment. If you received
this communication in error, please notify us immediately by e-mail and then delete all copies
of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet
is not secure. Do not send confidential or sensitive information, such as social security
numbers, account numbers, personal identification numbers and passwords, to us via ordinary
(unencrypted) e-mail.



Mime
View raw message