tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java
Date Thu, 24 Feb 2005 19:00:14 GMT

----- Original Message -----
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Thursday, February 24, 2005 9:04 AM
Subject: Re: cvs commit:
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core
ApplicationHttpRequest.java


>markt@apache.org wrote:
>> markt       2005/01/15 12:27:05
>>
>>   Modified:    catalina/src/share/org/apache/catalina/core
>>                         ApplicationHttpRequest.java
>>   Log:
>>   Fix bug 28222. request.getRequestURL() in forwarded jsp/servlet returns
>>     original url rather than new url as per SRV8.4. Uses same code as
>>     CoyoteRequest.getRequestURL()
>
>I think the bug report may actually be invalid, because:
>- getRequestURL is not a path element
>- the javadoc associated with the method is:
>Reconstructs the URL the client used to make the request. The returned
>URL contains a protocol, server name, port number, and server path, but
>it does not include query string parameters.
>
>
>I don't know for sure, however. Any comments on that ?
>

I'd tend to go with Remy's interpretation, but it is a grey area in the
spec.  The javadocs for HttpServletRequest.getRequestURI (which is a path
element) say to use the deprecated HttpUtils.getRequestURL to construct a
URL, which suggests that HttpUtils.getRequestURL should use the path
elements.  However the javadocs for HttpUtils.getRequestURL are pretty much
the same as for HttpServletRequest.getRequestURL, making the picture a bit
grey.

>Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org





This message is intended only for the use of the person(s) listed above as the intended recipient(s),
and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended
recipient, you may not read, copy, or distribute this message or any attachment. If you received
this communication in error, please notify us immediately by e-mail and then delete all copies
of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet
is not secure. Do not send confidential or sensitive information, such as social security
numbers, account numbers, personal identification numbers and passwords, to us via ordinary
(unencrypted) e-mail.



Mime
View raw message