tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <>
Subject Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http
Date Wed, 05 Jan 2005 20:42:00 GMT

----- Original Message -----
From: <>
To: <>
Sent: Wednesday, January 05, 2005 1:29 AM
Subject: cvs commit:

> remm        2005/01/05 01:29:19
>   Removed:     util/java/org/apache/tomcat/util/http
>   Log:
>   - I cannot clean IP in this file. If it is needed by Tomcat 3, I think
it'll need to be added back (with
>     proper attribution) to the Tomcat 3 codebase. Sorry for the trouble :(

Yup. Tomcat 3 does have references to it.  Fortunately, Xalan is currently
broken so Gump isn't nagging about it :).

The choices seem to be to re-add it to j-t (and have the o.a.t.u.http
package split across two jars), or to clean the references to it.  In the
first case, I'd propose removing the references to Sun, but leaving the
javadoc copy of Jason's attribution.

To clean it:  ErrorHandler is applying it to the platform Locale, which is
silly.  I'd propose adding a 'useCharset' attribute to ErrorHandler, and if
unset default to the Request charset (which is smarter).  StaticInterceptor
uses only for directory listings when its 'useCharset' attribute is set to
'locale'.  In this case, the charset could simply be an entry in the
associated ResourceBundle (since the current incarnation must look really
weird when it gets an 'Accept-Language: ar' request header :).

Personally, I can go either way on this one.

> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

This message is intended only for the use of the person(s) listed above as the intended recipient(s),
and may contain information that is PRIVILEGED and CONFIDENTIAL.  If you are not an intended
recipient, you may not read, copy, or distribute this message or any attachment. If you received
this communication in error, please notify us immediately by e-mail and then delete all copies
of this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet
is not secure. Do not send confidential or sensitive information, such as social security
numbers, account numbers, personal identification numbers and passwords, to us via ordinary
(unencrypted) e-mail.

View raw message