tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
Date Sat, 20 Nov 2004 09:17:41 GMT
billbarker@apache.org wrote:

>billbarker    2004/11/19 19:04:28
>
>  Modified:    http11/src/java/org/apache/coyote/http11
>                        Http11Processor.java
>  Log:
>  If we are in the error state, we aren't going to keep-alive.  So don't lie to the UA
that we are.
>  
>  Fix for Bug #32292
>  
>
-1. I disagree with this change, sorry. We are going to keepalive in 
this case (anything which isn't a status drop, which is the whole 
point). The error flag can be set by a sendError, which could send any 
status code.

>  
>  Revision  Changes    Path
>  1.113     +1 -1      jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
>  
>  Index: Http11Processor.java
>  ===================================================================
>  RCS file: /home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
>  retrieving revision 1.112
>  retrieving revision 1.113
>  diff -u -r1.112 -r1.113
>  --- Http11Processor.java	1 Oct 2004 23:36:15 -0000	1.112
>  +++ Http11Processor.java	20 Nov 2004 03:04:28 -0000	1.113
>  @@ -1542,7 +1542,7 @@
>           keepAlive = keepAlive && !statusDropsConnection(statusCode);
>           if (!keepAlive) {
>               headers.addValue(Constants.CONNECTION).setString(Constants.CLOSE);
>  -        } else if (!http11) {
>  +        } else if (!http11 && !error) {
>               headers.addValue(Constants.CONNECTION).setString(Constants.KEEPALIVE);
>           }
>  
>
Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message