tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Luehe <Jan.Lu...@Sun.COM>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector RequestFacade.java LocalStrings.properties
Date Mon, 01 Nov 2004 23:41:18 GMT
Remy Maucherat wrote:
> luehe@apache.org wrote:
> 
> 
>>luehe       2004/11/01 14:38:44
>>
>> Modified:    catalina/src/share/org/apache/catalina/connector
>>                       RequestFacade.java LocalStrings.properties
>> Log:
>> Throw more meaningful exception (instead of NPE) if underlying request has been
>> recycled and attempt is made to access it via its facade
>>
> 
> I think I always consistently refused this change (no use: if people who 
> hack can't be bothered to look that up in the code, then I don't think 
> they'll understand what your exception really means either), but I'll 
> give up on that one.

In this case, it's useful because rather than instinctively filing a bug
against Tomcat when seeing a NPE, people will be reminded to check their
code first, because they're obviously using Tomcat in a way it was not
intended to be used.

We just ran into this internally.


Jan


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message