tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31328] - DeltaRequest unable to handle two concurrent requests per session
Date Thu, 25 Nov 2004 22:25:48 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31328>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31328


alexander.schwartz@gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13003|0                           |1
        is obsolete|                            |




------- Additional Comments From alexander.schwartz@gmx.net  2004-11-25 23:25 -------
Created an attachment (id=13542)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=13542&action=view)
Code Cleanup; make getSize() synchronized

Hi Filip,

Thanks for putting the "synchronized" in the code in all relevant spots, it
should work now. Sorry for not providing a proper patch. 

For some paranoia reasons I'd like to see a synchronized with the getSize() --
it accessed the actions variable, all other accesses have been synchronized, to
this one should be synchronized as well.

As far as I can see the code will not produce exceptions any more if there are
parallel request in a session on one tomcat. THANK YOU VERY MUCH, FILIP!

Just some possible optimizations if someone cares: After introducing the
"synchronized" the some of the Exceptions ("Unable to remove element") can no
longer happen, it is safe to remove them.

Also I think that the "synchronized" in the inner class AttributeInfo is not
necessary as it is already called by synchronized methods of DeltaRequest. And
I also removed one NoSuchElementException that can not be thrown by a simple
remove(). A patch is included.

I do not reopen this bug, but maybe you find time to test and apply this patch.
A version like this is running in my production enviro

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message